-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-1765 Add Application Launch events tracking - all PRs combined #699
Merged
ncreated
merged 33 commits into
master
from
ncreated/RUMM-1765-app-launch-events-tracking
Dec 22, 2021
Merged
RUMM-1765 Add Application Launch events tracking - all PRs combined #699
ncreated
merged 33 commits into
master
from
ncreated/RUMM-1765-app-launch-events-tracking
Dec 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erty It also fixes the bug where existing, but inactive view scope was preventing "Background" view from being started. This was corresponding to the scenario when an app is sent to background while a resource is being loaded - until the resource finished, no "Background" view could be started.
this is to capture "app launch" events before starting first view.
with ensuring that only one listener is created for the entire SDK.
by ensuring that app starts "ApplicationLaunch" view only if launched in foreground and it starts "Background" view when launched in background with "Background Events Tracking" option enabled.
…a very first event in the view
… foreground / background state so it can be accessed in restarted session, when deciding on how to upload crash report.
so it can be used both in RUM and Crash Reporting for sampling session and/or crash report.
…application-launch-view-when-app-in-background RUMM-1765 Do not start "ApplicationLaunch" view when app launches in background - part 2
…aunch-crashes RUMM-1765 Update `CrashContext` with necessary info for handling App Launch crashes - part 3
…ssion while there was no Background view started.
…ion on app foreground state as `.active` is not enough to infer if app is in foreground. It might be also in foreground while the app state is `.inactive`.
…ch-crashes RUMM-1765 Handle App Launch crashes - part 4
…d-app-state-reporting-in-app-state-listener RUMM-1765 Fix foreground app state reporting in `AppStateListener` - part 5 🏁
RUMM-1765 Apply combined CR feedback
maxep
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! everything has been reviewed in mentioned PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This is a combined merge integrating all PRs on Application Launch events tracking:
CrashContext
with necessary info for handling App Launch crashes - part 3 #690AppStateListener
- part 5 🏁 #696How?
Only merging the feature branch to
master
.For the reference, here I'm leaving charts for implemented logic of tracking app launch events and crashes.
Review checklist