RUMM-824 Add API for customizing batch size and upload frequency #358
Conversation
| ) { | ||
| let meanFileAgeInSeconds: TimeInterval = { | ||
| switch (bundleType, batchSize) { | ||
| case (.iOSApp, .small): return 5 |
There was a problem hiding this comment.
Out of curiosity, what's the difference between iOSApp and iOSAppExtension ?
There was a problem hiding this comment.
this is due to GH issue number 52
(i'm not giving the actual refererence to it on purpose, no need to alert it i guess)
There was a problem hiding this comment.
iOS App Extensions are the way to add functionality beyond the app so they can interact with other apps or the system (e.g. home screen widgets).
We differentiate PerformancePreset in app extension, because its process is usually designed to work only for the very short amount of time, when the user interacts with it, e.g. chooses the Slack channel and message to upload photo directly from the iOS photo library through Slack Extension (w/o launching the Slack app).
Such PerformancePreset for app extension stores and uploads data much mor frequently + its initial upload is scheduled almost right away when the app extension starts. This is to make sure the SDK has enough chance to upload all data before the extension is closed (which usually happens in few seconds after it was started).
ncreated
deleted the
ncreated/RUMM-824-RUMM-823-add-api-for-custom-upload-frequency-and-batch-size
branch
What and why?
📦 This PR adds two new public APIs, so that the user can customize the size and frequency of requests made by the SDK.
How?
The write / upload settings were already abstracted by
PerformancePresettype, so this PR just configures its values depending on theBatchSizeandUploadFrequencyreceived from the user with two new public APIs:Because the iOS SDK provides different presets for iOS apps and iOS app extensions, the values computed for
PerformancePresetare additionally customized to work well in short-lived app extension environment.The
PerformancePresetcomputed for iOS app is unified with the values introduced for Android SDK DataDog/dd-sdk-android#454 and DataDog/dd-sdk-android#453.The new APIs are also exposed for Objc SDK.
Review checklist