Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

outdated type definitions for LogsInitConfiguration #2685

Closed
swseverance opened this issue Apr 3, 2024 · 0 comments · Fixed by #2686
Closed

outdated type definitions for LogsInitConfiguration #2685

swseverance opened this issue Apr 3, 2024 · 0 comments · Fixed by #2686
Labels
bug Something isn't working

Comments

@swseverance
Copy link

Describe the bug
Please update the LogsInitConfiguration interface so that beforeSend incorporates the newly added context parameter.

browser-sdk/packages/logs/src/domain/configuration.ts

Line 17 in 61258c1

beforeSend?: ((event: LogsEvent) => boolean) | undefined

See #2665

cc @thomas-lebeau @BenoitZugmeyer

Expected behavior
The interface is updated
@swseverance swseverance added the bug Something isn't working label Apr 3, 2024
@thomas-lebeau thomas-lebeau mentioned this issue Apr 4, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 fix beforeSend type definition for logs DataDog/browser-sdk
1 participant
@swseverance