Add support for Universal Service Monitoring sysprobe configuration #458
Conversation
marcus-crane
changed the title
marcus-crane
changed the title
tasks/agent-linux.yml
Outdated
| and service_monitoring_config['enabled'])) | ||
| and datadog_sysprobe_installed }}" | ||
| when: not datadog_skip_running_check | ||
| and (not datadog_before_7180) |
There was a problem hiding this comment.
Ah woops, this should be datadog_before_7400
|
@alai97 Is there anything else I need to do in order to have this merged or reviewed further? 🤔 |
There was a problem hiding this comment.
Hi @marcus-crane,
Sorry for the late review, and thanks for your contribution! This PR looks good to me overall.
Regarding the Agent 6 / Agent 7 difference, I checked with the USM product owners, and USM should also work on Agent 6 (they will be working on updating the documentation page). Could you also add the service_monitoring_config option to the ci_test/install_agent_6.yaml test config?
|
@KSerrania Heya, just letting you know that I've implemented the v6 change 🙂 I see that USM appears to have moved over to Public Beta with it being pushed visibly in the UI so it'll be nice to be able to set this up via Ansible (we've currently just been manually enabling it on a few instances given the existing config can't express the options needed) |
Closes: #457
As mentioned in #457, the Ansible stack doesn't currently support adding a
service_monitoring_configintosystem-probe.yamlso this PR is an attempt to add that.I'm very much pattern matching here so I wanted to open a PR with what I have currently to get some feedback: Mainly I'm unsure about some of the v6 CI pipelines which have configuration for v7 features.
I figure that is probably intentional to assert that v6 agents don't use v7 features?
Anyway, let me know if this is usable 🙂