Skip to content

Remove temporary dir after apt key import #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Remove temporary dir after apt key import #442

merged 1 commit into from
Jul 8, 2022

Conversation

wisnij
Copy link
Contributor

@wisnij wisnij commented Jun 24, 2022

Remove the temporary directory created by _apt_key_import.yml after
importing the key, so they don't pile up in the hosts' /tmp dirs.

Remove the temporary directory created by `_apt_key_import.yml` after
importing the key, so they don't pile up in the hosts` `/tmp` dirs.
@wisnij wisnij requested a review from a team as a code owner June 24, 2022 17:52
@wisnij
Copy link
Contributor Author

wisnij commented Jun 24, 2022

Tested locally on a host using this role:

TASK [datadog.datadog : Create temporary directory for key manipulation] *******
ok: [localhost]

TASK [datadog.datadog : Download https://s3.amazonaws.com/public-signing-keys/DATADOG_APT_KEY_CURRENT.public to import key DATADOG_APT_KEY_CURRENT] ***
ok: [localhost]

TASK [datadog.datadog : Ensure downloaded file for DATADOG_APT_KEY_CURRENT is a binary keyring] ***
ok: [localhost]

TASK [datadog.datadog : Extract the required key from the binary keyring (when not DATADOG_APT_KEY_CURRENT)] ***
skipping: [localhost]

TASK [datadog.datadog : Extract the required key from the binary keyring (when DATADOG_APT_KEY_CURRENT)] ***
ok: [localhost]

TASK [datadog.datadog : Import key DATADOG_APT_KEY_CURRENT to /usr/share/keyrings/datadog-archive-keyring.gpg keyring] ***
ok: [localhost]

TASK [datadog.datadog : Remove temporary directory for key manipulation] *******
ok: [localhost]

Copy link
Contributor

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks for the PR, I'm merging.

@bkabrda bkabrda merged commit 63eb433 into DataDog:main Jul 8, 2022
@briantist
Copy link

Thanks @bkabrda ! When do you expect the next release which will include this change?

@bkabrda
Copy link
Contributor

bkabrda commented Jul 11, 2022

@briantist I've just released version 4.16.0 which includes this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants