Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check datadog_checks to avoid misconfiguration #384

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

soar
Copy link
Contributor

@soar soar commented Aug 26, 2021

A misconfiguration like:

roles:
  - { name: datadog.datadog, datadog_checks: _datadog_checks }

leads to looping over a string and creating a lot of directories in /etc/datadog-agent/conf.d/. I propose to add a check for this.

@soar soar requested a review from a team as a code owner August 26, 2021 11:08
Copy link
Contributor

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 thanks a lot for the PR. It looks good, I just suggested a small change that would ensure the name of the task is a little bit more descriptive. If that looks good to you, let's get it applied and merged.

tasks/sanitize-checks.yml Outdated Show resolved Hide resolved
@bkabrda bkabrda merged commit a474c0e into DataDog:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants