-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linter and fix issues found #340
Conversation
It never (testesd in 2.6 and 2.10) worked: wildcards aren't expanded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
About the file permissions: we're already making the Agent 6/7 main config file not world-readable. Should we do the same for the integrations config files, the config dir itself? And should we do the same for the Agent 5 config too?
I've just added a FIXME for A5, the same way I added a FIXME for Windows in the original changes. Those are breaking changes so they will have to wait until a new major version. The Windows one is a bit more worrying than A5. About the directories themselves, I don't think it's a security issue that they are accessible by anyone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No docs review required
Bumps the linter docker image and fixes the following warnings:
role_name
andnamespace
missing from metadata.