Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linter and fix issues found #340

Merged
merged 5 commits into from
Mar 30, 2021
Merged

Conversation

albertvaka
Copy link
Contributor

Bumps the linter docker image and fixes the following warnings:

  • File permissions not being explicit.
  • role_name and namespace missing from metadata.
  • Wildcards used in pre/post tasks are not expanded (confirmed manually in 2.6 and 2.10)-> I removed the tasks since they never worked so nobody must be using them.

@albertvaka albertvaka requested review from a team as code owners March 29, 2021 10:50
Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

About the file permissions: we're already making the Agent 6/7 main config file not world-readable. Should we do the same for the integrations config files, the config dir itself? And should we do the same for the Agent 5 config too?

tasks/agent5-linux.yml Outdated Show resolved Hide resolved
tasks/agent5-linux.yml Outdated Show resolved Hide resolved
@albertvaka
Copy link
Contributor Author

I've just added a FIXME for A5, the same way I added a FIXME for Windows in the original changes. Those are breaking changes so they will have to wait until a new major version. The Windows one is a bit more worrying than A5. About the directories themselves, I don't think it's a security issue that they are accessible by anyone.

Copy link

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No docs review required

@albertvaka albertvaka merged commit 7f7d8aa into master Mar 30, 2021
@albertvaka albertvaka deleted the albertvaka/update-linter branch March 30, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants