Change configuration perms on Linux #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent main & check configuration files to be read by everybody. The reason is they can contains some secrets. Before this modification we had something like that: ``` $ ls -lah /etc/datadog-agent/conf.d/mysql.d/conf.yaml -rw-r--r-- 1 dd-agent dd-agent 657 Nov 30 15:15 /etc/datadog-agent/conf.d/mysql.d/conf.yaml $ ls -lah /etc/datadog-agent/datadog.yaml -rw-r--r-- 1 dd-agent dd-agent 215 Nov 30 15:09 /etc/datadog-agent/datadog.yaml ``` After it become: ``` $ ls -lah /etc/datadog-agent/datadog.yaml -rw-r----- 1 dd-agent dd-agent 215 Dec 1 12:26 /etc/datadog-agent/datadog.yaml $ ls -lah /etc/datadog-agent/conf.d/mysql.d/conf.yaml -rw-r----- 1 dd-agent dd-agent 657 Dec 1 12:26 /etc/datadog-agent/conf.d/mysql.d/conf.yaml ``` Fix #312
|
Thanks a lot for your patch! I think changing this makes sense, specially since we already secure those files for Chef and Puppet users. Also: Loving your Alex Kidd avatar :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent main & check configuration files to be read by everybody.
The reason is they can contains some secrets, we unfortunately switch to the fork because of that…
Before this modification we had something like that:
After it become:
Fix #312