Do not name the RPM repo file differently depending on the Agent version #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use 'datadog' as a name, to be consistent with other install methods.
albertvaka
force-pushed
the
albertvaka/rpm-repo-filename
branch
from
9380d4e to
a2f9e0e
Compare
KSerrania
reviewed
Nov 26, 2020
tasks/pkg-redhat.yml
Outdated
| yum_repository: | ||
| name: "ansible_datadog_{{ item }}.repo" | ||
| state: absent | ||
| with_items: [ 5, 6, 7 ] |
There was a problem hiding this comment.
I think we also want to run this with custom, to remove the custom yum repository (if it exists).
There was a problem hiding this comment.
Done and fixed the tests that were failing.
albertvaka
force-pushed
the
albertvaka/rpm-repo-filename
branch
from
8a8039a to
f15d50f
Compare
KSerrania
reviewed
Dec 1, 2020
Co-authored-by: Kylian Serrania <[email protected]>
KSerrania
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use
datadog.repoas the name, to be consistent with other install methods.Motivation
We might want the repo file to be installed with the package manager in the future, and we don't want to end up with two of them. I'm still not sure how managing this file with Ansible will interact with the package manager trying to install a newer version of the file (eg: because we added a new GPG key). In case the package manager replaces the file (which I think is not the default behavior, but can be configured that way), Ansible will change it back anyway in the next run 🤷 In any case, that's a problem we will have to solve for all config management tools, so I think this change is still making things better by making all install methods consistent.