feat(ansible_facts): replace injected facts 'ansible_' with dictionary 'ansible_facts' #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…facts' dictionary
|
👋 Thanks for the patch! I've tested this on the oldest Ansible we support (2.6) and it works well even there, so I think we can merge it ✅ Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Ansible Documentation on Facts this MR replace injected variables prefixed with
ansible_with dictionaryansible_factsUsing facts with prefix was changed in Ansible 2.5, and should be disabled by default in future releases. In cases where users choose to force only
ansible_factsto be used by settinginject_facts_as_varsto False, using older naming leads to errors when applying the role.