Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added analytics readme (#2436) #2442

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

jpaten
Copy link
Contributor

@jpaten jpaten commented Sep 21, 2024

No description provided.

@github-actions github-actions bot added the canary Done by the Clever Canary label Sep 21, 2024
@jpaten jpaten force-pushed the jonah/2436-create-analytics-readme branch 5 times, most recently from 8347593 to c4d4843 Compare September 21, 2024 01:03
@jpaten jpaten marked this pull request as draft October 3, 2024 21:44
@jpaten jpaten self-assigned this Nov 8, 2024
@jpaten jpaten force-pushed the jonah/2436-create-analytics-readme branch from c4d4843 to dce95c8 Compare November 8, 2024 18:01
@jpaten jpaten marked this pull request as ready for review November 8, 2024 18:02
Copy link
Contributor

@MillenniumFalconMechanic MillenniumFalconMechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jpaten! Added two suggestions, and it looks like there's a Prettier error?

@@ -0,0 +1,12 @@
## HCA Portal Analytics Config

The HCA Portal reports various events using Google Analytics 4 tags. Most of these events are defined in [findable-ui](https://github.com/databiosphere/findable-ui), and are documented in its [analytics readme](https://github.com/DataBiosphere/findable-ui/blob/main/src/common/analytics/readme-analytics.md). Custom events and ids that are defined in this repo specifically are below
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The HCA Portal reports various events using Google Analytics 4 tags. Most of these events are defined in [findable-ui](https://github.com/databiosphere/findable-ui), and are documented in its [analytics readme](https://github.com/DataBiosphere/findable-ui/blob/main/src/common/analytics/readme-analytics.md). Custom events and ids that are defined in this repo specifically are below
The HCA Portal reports various events using Google Analytics 4 tags. Most of these events are defined in [findable-ui](https://github.com/databiosphere/findable-ui), and are documented in its [analytics readme](https://github.com/DataBiosphere/findable-ui/blob/main/src/common/analytics/readme-analytics.md). Custom events and ids that are defined in this repo specifically are below.


#### Custom Events

There are no custom events configured in this repository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are no custom events configured in this repository
There are no custom events configured in this repository.

@jpaten jpaten force-pushed the jonah/2436-create-analytics-readme branch 2 times, most recently from eb6f929 to cf12817 Compare November 8, 2024 20:51
@jpaten jpaten force-pushed the jonah/2436-create-analytics-readme branch from cf12817 to 0e3c3da Compare November 8, 2024 21:01
@NoopDog NoopDog merged commit 2aba3ec into main Nov 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canary Done by the Clever Canary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HCA Portal] Validate pageview events are accessible on the GA4 Query Explorer for dev and prod
3 participants