Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary ClearKeyKeySet import in index.d.ts #2807

Closed
howardpanton opened this issue Oct 12, 2018 · 1 comment
Closed

Unnecessary ClearKeyKeySet import in index.d.ts #2807

howardpanton opened this issue Oct 12, 2018 · 1 comment

Comments

@howardpanton
Copy link

There is a ClearKeyKeySet import at the top of the type file.
https://github.com/Dash-Industry-Forum/dash.js/blob/development/index.d.ts#L1
`
import ClearKeyKeySet from "./src/streaming/protection/vo/ClearKeyKeySet";

export = dashjs;
export as namespace dashjs;
This import is unused and causes a typescript build error when using dash.js with Angular.
[ts]
Could not find a declaration file for module './src/streaming/protection/vo/ClearKeyKeySet'. '/Users/howardpanton/Sites/m2a-dashboard-beta/node_modules/dashjs/src/streaming/protection/vo/ClearKeyKeySet.js' implicitly has an 'any' type.
`

@nicosang
Copy link
Contributor

Hi @howardpanton ,

thanks for pointing this out but this issue has been fixed in PR Remove import from typings file #2792.
It will be available in the next 2.9.2 release.

Nico

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants