add support for ivy and completing-read #18
Conversation
|
I haven't touched the tests either - again, I want to be sure you're OK with the direction first. |
|
I think what you have done is great! Are you willing to go to the end of it and suggest several packages to melpa? |
|
Sure. I've never done any melpa packaging before (I have a few other local elisp packages that probably should be pushed there too), but not a problem |
|
Thank you! |
This separates the helm specific parts into their own file.
|
Thank you very much for working on this. Please keep me informed. |
|
Hi Damien, it obviously hasn’t gotten a lot of attention as you can see.
If I was to add support for using emacs’s completing-read functionality, would you prefer that directly in vdirel.el or should that also move out into a separate file like helm and ivy? I would argue the former since it’s built-in.
|
👍 for adding the support to vdirel.el file directly. |
peterhoeg
changed the title
|
oh, and I should really do tests. |
|
@peterhoeg thank you for your work. Please ping me when you feel ready. In the meantime, I converted your PR to draft. |
|
In the meantime, I converted your PR to draft.
I thought of doing exactly that while I was on the road. Thanks for being ahead of me!
|
|
Very interested in seeing this merged. Good work so far! |
This is what I'm using on my side as I don't use helm.
I can definitely do up some documentation, but before I start writing a novel, I want to be sure you're OK with this.
A few changes here:
I have a change ready to PR for melpa for the helm and ivy packages.