Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (gen:endpoint): Remove "s" after "<%= name %>" in endpoint templates #298

Closed

Conversation

covertgeek
Copy link

The endpoint generator adds an additional "s" to the controller and test spec files. This is to remove the additional "s" in the templates.

The endpoint generator adds an additional "s" to the controller and test spec files.  This is to remove the additional "s" in the templates.
@DaftMonk DaftMonk closed this in 163cacf Jul 3, 2014
@DaftMonk
Copy link
Member

DaftMonk commented Jul 3, 2014

Thanks for pointing this out. Had to do a slightly different fix though.

@covertgeek
Copy link
Author

@DaftMonk I believe this is issue in the name.controller.js file also. Do you agree?

@DaftMonk
Copy link
Member

DaftMonk commented Jul 3, 2014

Not sure if theres something specific you're referring to, but the controller looks fine to me.

@covertgeek
Copy link
Author

I was mistaken. In the index function (ln 9 & 11), I saw the pluralization of the model and made an assumption. It makes sense now and isn't actually an issue. Thanks for your patience with a newbie. :)

@covertgeek covertgeek deleted the fix_endpoints branch July 3, 2014 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants