Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding relationships from the edit item page is broken #1103

Closed
artlowel opened this issue Apr 15, 2021 · 5 comments · Fixed by #1139
Closed

Adding relationships from the edit item page is broken #1103

artlowel opened this issue Apr 15, 2021 · 5 comments · Fixed by #1139
Assignees
Labels
Milestone

Comments

@artlowel
Copy link
Member

Describe the bug
If you try to add a relationship from the edit item tab as an admin the modal it will keep loading. It looks like this was broken by #1025, where a number of observables specific to the submission where added to the modal and used to determine when to show the loading component

To Reproduce
Steps to reproduce the behavior:

  1. Authenticate as an admin
  2. Go to an edit item page, on the relationships tab
  3. Try to add a relationship

Expected behavior
The modal should work properly both in the submission and on the edit item page.

Related work
#1025

@artlowel artlowel added bug needs triage New issue needs triage and/or scheduling labels Apr 15, 2021
@artlowel artlowel changed the title Adding relationship from the edit item page is broken Adding relationships from the edit item page is broken Apr 15, 2021
@tdonohue tdonohue added this to the 7.0 milestone Apr 15, 2021
@tdonohue
Copy link
Member

@artlowel : Assigning this back to you for analysis & estimation. It sounds like something that should be fixed in 7.0, so I gave it a medium priority.

@tdonohue tdonohue added Estimate TBD and removed needs triage New issue needs triage and/or scheduling labels Apr 16, 2021
@artlowel
Copy link
Member Author

@atarix83 Could you tell me why this setItem method was added? The item was already being set by the method that initializes the modal in the submission and on the edit item page, and was independent of anything submission related. At first sight it seems like simply removing setItem could fix this issue.

@atarix83
Copy link
Contributor

atarix83 commented Apr 20, 2021

@artlowel that method has been added to retrieve the item end collection when I've tried to place the lookup button, along the Add more button in the form.component. There, both item and collection are not available so I made that method. In the current implementation is not needed but we should keep in mind if we'll move the lookup button as suggested by @tdonohue here

@artlowel
Copy link
Member Author

In that case we can fix it in 1 hour

@artlowel artlowel assigned tdonohue and unassigned artlowel Apr 22, 2021
@tdonohue tdonohue added e/1 Estimate in hours and removed Estimate TBD labels Apr 22, 2021
@tdonohue tdonohue assigned artlowel and unassigned tdonohue Apr 22, 2021
@tdonohue
Copy link
Member

Sounds good @artlowel . I've assigned back to your team to begin work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants