fix: added extraction of byte-images in excel #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiun An Tsai <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
PeterStaar-IBM
changed the title
Closed
3 tasks
Signed-off-by: Peter Staar <[email protected]>
dolfim-ibm
previously approved these changes
Jan 24, 2025
vagenas
reviewed
Jan 24, 2025
Signed-off-by: Peter Staar <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
dolfim-ibm
previously approved these changes
Jan 24, 2025
nikos-livathinos
previously approved these changes
Jan 24, 2025
…ecking_in_find_images_in_sheet Signed-off-by: Michele Dolfi <[email protected]>
dolfim-ibm
dismissed stale reviews from nikos-livathinos and themself
via
476c025
dolfim-ibm
approved these changes
Jan 24, 2025
nikos-livathinos
approved these changes
Jan 24, 2025
dolfim-ibm
deleted the
bugfix/ignore_mypy_checking_in_find_images_in_sheet
branch
vancura
pushed a commit
to vancura/docling
that referenced
this pull request
Feb 6, 2025
* fix(msexcel): ignore Mypy checking for _find_images_in_sheet function Signed-off-by: Jiun An Tsai <[email protected]> * fixed some issues Signed-off-by: Peter Staar <[email protected]> * reformatted the code Signed-off-by: Peter Staar <[email protected]> * pinned pillow in pyproject Signed-off-by: Peter Staar <[email protected]> --------- Signed-off-by: Jiun An Tsai <[email protected]> Signed-off-by: Peter Staar <[email protected]> Signed-off-by: Michele Dolfi <[email protected]> Co-authored-by: Jiun An Tsai <[email protected]> Co-authored-by: Michele Dolfi <[email protected]> Signed-off-by: Václav Vančura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: