Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kaguyasp2isis is listed under "utility" instead of "mission specific programs" and update docs to indicate kaguyasp2ascii should be used instead. #3876

Closed
lavalaz opened this issue May 22, 2020 · 7 comments
Assignees
Labels
bug Something isn't working Products Issues which are impacting the products group

Comments

@lavalaz
Copy link

lavalaz commented May 22, 2020

Description

This application is listed under the wrong heading on the website https://isis.astrogeology.usgs.gov/Application/index.html#Utility
Suggested Edit

List it under Kaguya under Missions.
Thanks!

@jessemapel jessemapel added the bug Something isn't working label May 22, 2020
@jlaura jlaura added the Products Issues which are impacting the products group label May 22, 2020
@krlberry
Copy link
Contributor

krlberry commented Jun 11, 2020

I actually think that the solution to this ticket is to remove the kaguyasp2isis program from ISIS. It was announced that this program was being updated and renamed to kaguyasp2ascii in 2015 (See: https://isis.astrogeology.usgs.gov/Application/presentation/Tabbed/kaguyasp2ascii/kaguyasp2ascii.html) but it looks like the old version (kaguyasp2isis) was never actually removed.

That being said, since it wasn't removed in 2015, would we need to give more warning about removing it now? Right now, looking at it, kaguyasp2isis is just an old version of kaguyasp2ascii that won't work on newer formats of input files.

@thareUSGS
Copy link

Are you recommending moving this to somewhere like: https://github.com/USGS-Astrogeology/ISIS_contrib ? I think that is reasonable especially since you don't think it works on newer files.

@krlberry
Copy link
Contributor

krlberry commented Jun 11, 2020

Talked about this during the stand up. Since kaguyasp2ascii is just a newer version of kaguyasp2isis this ticket now contains the following work:

(1) Still update this so it is listed under the Kaguya mission instead of under utilities
(2) Update the kaguyasp2isis documentation to link to the kaguyasp2ascii documentation and say something along the lines of: "Use kaguaysp2ascii -- it's a newer version of kaguyasp2isis that was renamed since it doesn't actually import cubes into ISIS" with a warning about a future deprecation date.

@krlberry krlberry changed the title kaguyasp2isis is listed under "utility" instead of "mission specific programs" kaguyasp2isis is listed under "utility" instead of "mission specific programs" and update docs to indicate kaguyasp2ascii should be used instead. Jun 11, 2020
@lavalaz
Copy link
Author

lavalaz commented Jun 11, 2020

FWIW, I think this is a perfect solution. Thank you!

@jlaura
Copy link
Collaborator

jlaura commented Jun 15, 2020

@kberryUSGS Did this get updated? Can we close?

@krlberry
Copy link
Contributor

@jlaura It didn't get updated. I only updated the ticket with more information.

@Kelvinrr
Copy link
Collaborator

Kelvinrr commented Sep 4, 2020

closed by #3996

@Kelvinrr Kelvinrr closed this as completed Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Products Issues which are impacting the products group
Projects
None yet
Development

No branches or pull requests

6 participants