Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend t8_gtest_geometry_linear test to axis aligned tests. #980

Closed
Davknapp opened this issue Mar 8, 2024 · 1 comment · Fixed by #914
Closed

Extend t8_gtest_geometry_linear test to axis aligned tests. #980

Davknapp opened this issue Mar 8, 2024 · 1 comment · Fixed by #914

Comments

@Davknapp
Copy link
Collaborator

Davknapp commented Mar 8, 2024 •
edited
Loading

Currently the axis aligned geometry is nearly untested, but is used in several use cases. We should invest some time to extend our testsuite.

We should especially check, that our geometries evaluate correctly. The root of the bug in #977 was that the axis-aligned geometry did not evaluate correctly.
@Davknapp Davknapp mentioned this issue Mar 8, 2024
Merged
14 tasks
@sandro-elsweijer
Copy link
Collaborator

There is already a PR for that #914

@sandro-elsweijer sandro-elsweijer mentioned this issue Mar 8, 2024
Merged
14 tasks
@sandro-elsweijer sandro-elsweijer linked a pull request Mar 8, 2024 that will close this issue
Test add linear axis aligned geometry test #914
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test add linear axis aligned geometry test DLR-AMR/t8code
2 participants
@Davknapp @sandro-elsweijer