Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more than 2 processes in testing #68

Closed
holke opened this issue Mar 12, 2021 · 5 comments
Closed

Use more than 2 processes in testing #68

holke opened this issue Mar 12, 2021 · 5 comments

Comments

@holke
Copy link
Collaborator

holke commented Mar 12, 2021

The test runner is currently configured to use mpirun -np 2.
We should increase the number of parallel processes to at least 4.

This is configured in the variable SC_MPI_TEST_FLAGS or T8_MPI_TEST_FLAGS

@Davknapp
Copy link
Collaborator

Do you know where the variable is set?
Grepping for it only results in
t8code/Makefile.am:LOG_COMPILER = @T8_MPIRUN@ @T8_MPI_TEST_FLAGS@
and the search for T8_MPIRUN leads to the same, starting from a fresh download of t8code

@holke
Copy link
Collaborator Author

holke commented Jun 18, 2024

This is set in the sc library, so we would need to change it for sc and hence all packages using sc.

However, maybe writing a t8_mpi.m4 that overwrites the sc setting for T8_MPI_TEST_FLAG works?

https://github.com/cburstedde/libsc/blob/master/config/sc_mpi.m4

@cburstedde
Copy link
Collaborator

cburstedde commented Jun 18, 2024 via email

@holke
Copy link
Collaborator Author

holke commented Jul 19, 2024

#1139 #1134 add configure options to control the number of processes that tests are run on.

The only remaining step is to add more than 2 processes to the CI.

Also related to #1088

@Davknapp
Copy link
Collaborator

Davknapp commented Oct 9, 2024

Our CI now uses 4 procs to test and one can also provide a custom command in the CMake build-system to execute the tests.

@Davknapp Davknapp closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants