Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch "#ifdef T8_ENABLE_*" in files before commit #1374

Closed
holke opened this issue Feb 3, 2025 · 0 comments · Fixed by #1375
Closed

Catch "#ifdef T8_ENABLE_*" in files before commit #1374

holke opened this issue Feb 3, 2025 · 0 comments · Fixed by #1375
Assignees

Comments

@holke
Copy link
Collaborator

holke commented Feb 3, 2025

Feature request

Add a script that checks files with content "#ifdef T8_ENABLE_*" and prevent them from being committed.

Is your feature request related to a problem? Please describe.

See #1370
We noticed that we often use "#ifdef" but should be using "#if".
To prevent further missusage these errors should be caught early.

Describe the solution or feature you'd like

A script that given an input file checks for the strings
"#ifdef T8_ENABLE_*" (OCC/VTK/DEBUG) and returns error when found.
Call this script inside the commit hook for each file.
Abort the commit if string was found.

Describe alternatives you've considered
None

Estimated priority

"Priority: medium"

Additional context
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants