From 4ebab16415691e6bb97f2938a764bd83065ea766 Mon Sep 17 00:00:00 2001 From: Sandro Elsweijer Date: Thu, 18 Jul 2024 09:50:40 +0200 Subject: [PATCH] use pedantic build mode in cmake ci --- .../workflows/tests_t8code_cmake_linkage_parallel_debug.yml | 3 +-- .../workflows/tests_t8code_cmake_linkage_parallel_release.yml | 3 +-- .github/workflows/tests_t8code_cmake_parallel.yml | 3 +-- .github/workflows/tests_t8code_cmake_serial.yml | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/.github/workflows/tests_t8code_cmake_linkage_parallel_debug.yml b/.github/workflows/tests_t8code_cmake_linkage_parallel_debug.yml index 0de1afaf60..d5f1f6c890 100644 --- a/.github/workflows/tests_t8code_cmake_linkage_parallel_debug.yml +++ b/.github/workflows/tests_t8code_cmake_linkage_parallel_debug.yml @@ -182,8 +182,7 @@ jobs: run: export LESS_TEST_OPTION="-DT8CODE_ENABLE_LESS_TESTS=ON" && echo LESS_TEST_OPTION="$LESS_TEST_OPTION" >> $GITHUB_ENV - name: build config variables - #TODO: Werror - run: export CONFIG_OPTIONS="${LESS_TEST_OPTION} -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON" + run: export CONFIG_OPTIONS="${LESS_TEST_OPTION} -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON -DT8CODE_BUILD_PEDANTIC=ON" && export CONFIG_DEBUG="$CONFIG_OPTIONS -DCMAKE_BUILD_TYPE=Debug -DSC_DIR=$SC_DEBUG/install/cmake -DP4EST_DIR=$P4EST_DEBUG/install/cmake" && echo CONFIG_OPTIONS="$CONFIG_OPTIONS" >> $GITHUB_ENV && echo CONFIG_DEBUG="$CONFIG_DEBUG" >> $GITHUB_ENV diff --git a/.github/workflows/tests_t8code_cmake_linkage_parallel_release.yml b/.github/workflows/tests_t8code_cmake_linkage_parallel_release.yml index fd3386e3ee..a15c517bbf 100644 --- a/.github/workflows/tests_t8code_cmake_linkage_parallel_release.yml +++ b/.github/workflows/tests_t8code_cmake_linkage_parallel_release.yml @@ -182,8 +182,7 @@ jobs: run: export LESS_TEST_OPTION="-DT8CODE_ENABLE_LESS_TESTS=ON" && echo LESS_TEST_OPTION="$LESS_TEST_OPTION" >> $GITHUB_ENV - name: build config variables - #TODO: Werror - run: export CONFIG_OPTIONS="${LESS_TEST_OPTION} -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON" + run: export CONFIG_OPTIONS="${LESS_TEST_OPTION} -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON -DT8CODE_BUILD_PEDANTIC=ON" && export CONFIG_RELEASE="$CONFIG_OPTIONS -DCMAKE_BUILD_TYPE=Release -DSC_DIR=$SC_RELEASE/install/cmake -DP4EST_DIR=$P4EST_RELEASE/install/cmake" && echo CONFIG_OPTIONS="$CONFIG_OPTIONS" >> $GITHUB_ENV && echo CONFIG_RELEASE="$CONFIG_RELEASE" >> $GITHUB_ENV diff --git a/.github/workflows/tests_t8code_cmake_parallel.yml b/.github/workflows/tests_t8code_cmake_parallel.yml index c75f3df293..e6187ebd3f 100644 --- a/.github/workflows/tests_t8code_cmake_parallel.yml +++ b/.github/workflows/tests_t8code_cmake_parallel.yml @@ -181,8 +181,7 @@ jobs: run: export LESS_TEST_OPTION="-DT8CODE_ENABLE_LESS_TESTS=ON" && echo LESS_TEST_OPTION="$LESS_TEST_OPTION" >> $GITHUB_ENV - name: build config variables - #TODO: Werror - run: export CONFIG_OPTIONS="${LESS_TEST_OPTION} -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON" + run: export CONFIG_OPTIONS="${LESS_TEST_OPTION} -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON -DT8CODE_BUILD_PEDANTIC=ON" && export CONFIG_DEBUG="$CONFIG_OPTIONS -DCMAKE_BUILD_TYPE=Debug -DSC_DIR=$SC_DEBUG/install/cmake -DP4EST_DIR=$P4EST_DEBUG/install/cmake" && export CONFIG_RELEASE="$CONFIG_OPTIONS -DCMAKE_BUILD_TYPE=Release -DSC_DIR=$SC_RELEASE/install/cmake -DP4EST_DIR=$P4EST_RELEASE/install/cmake" && echo CONFIG_OPTIONS="$CONFIG_OPTIONS" >> $GITHUB_ENV diff --git a/.github/workflows/tests_t8code_cmake_serial.yml b/.github/workflows/tests_t8code_cmake_serial.yml index 39e0ea7a10..35e195ec17 100644 --- a/.github/workflows/tests_t8code_cmake_serial.yml +++ b/.github/workflows/tests_t8code_cmake_serial.yml @@ -181,8 +181,7 @@ jobs: run: export LESS_TEST_OPTION="-DT8CODE_ENABLE_LESS_TESTS=ON" && echo LESS_TEST_OPTION="$LESS_TEST_OPTION" >> $GITHUB_ENV - name: build config variables - #TODO: Werror - run: export CONFIG_OPTIONS="${LESS_TEST_OPTION} -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON -DT8CODE_ENABLE_MPI=OFF" + run: export CONFIG_OPTIONS="${LESS_TEST_OPTION} -DT8CODE_USE_SYSTEM_SC=ON -DT8CODE_USE_SYSTEM_P4EST=ON -DT8CODE_ENABLE_MPI=OFF -DT8CODE_BUILD_PEDANTIC=ON" && export CONFIG_SERIAL_DEBUG="$CONFIG_OPTIONS -DCMAKE_BUILD_TYPE=Debug -DSC_DIR=$SC_SERIAL_DEBUG/install/cmake -DP4EST_DIR=$P4EST_SERIAL_DEBUG/install/cmake" && export CONFIG_SERIAL_RELEASE="$CONFIG_OPTIONS -DCMAKE_BUILD_TYPE=Release -DSC_DIR=$SC_SERIAL_RELEASE/install/cmake -DP4EST_DIR=$P4EST_SERIAL_RELEASE/install/cmake" && echo CONFIG_OPTIONS="$CONFIG_OPTIONS" >> $GITHUB_ENV