Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of deprecated draft-IERC20Permit #89

Open
codehawks-bot opened this issue Aug 7, 2023 · 1 comment
Open

Use of deprecated draft-IERC20Permit #89

codehawks-bot opened this issue Aug 7, 2023 · 1 comment
Labels
finding-draft-i human-checked info

Comments

@codehawks-bot
Copy link

Use of deprecated draft-IERC20Permit

Severity

Low Risk

Relevant GitHub Links

https://github.com/Cyfrin/2023-07-beedle/blob/main/src/Beedle.sol#L6

Summary

The Beedle contract uses deprecated draft-ERC20Permit contract.

Vulnerability Details

According to OpenZeppelin update:

ERC20Permit: Added the file IERC20Permit.sol and ERC20Permit.sol and deprecated draft-IERC20Permit.sol and draft-ERC20Permit.sol since EIP-2612 is no longer a Draft. Developers are encouraged to update their imports. (#3793)

Tools Used

Manual review

Recommendations

Use ERC20Permit instead deprecated draft-IERC20Permit.
@PatrickAlphaC
Copy link
Member

Good suggestion, not a security issue per se, moving to info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
finding-draft-i human-checked info
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PatrickAlphaC @codehawks-bot