move patcher management to dedicated top level nav item and page #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves patchers to a top level page / nav item and replaces the "Patchers" Button with a simple "+" button on graph editor view.
I've not added the "default preset for new instances" behaviour yet as it seems that is not exposed via
/rnbo/patchersbut maybe now it would make sense to add the management of that into the top-level patcher view, rather than controlling it from the individual instance page?Could potentially extend this to also allow preset management for patchers in the new page rather than forcing the user to instantiate an instance first?
What do you think @x37v ?
Closes #200