Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for post-delete helm hook to be optionally disabled #278

Closed
congiv opened this issue Apr 12, 2024 · 3 comments · Fixed by #279
Closed

Allow for post-delete helm hook to be optionally disabled #278

congiv opened this issue Apr 12, 2024 · 3 comments · Fixed by #279

Comments

@congiv
Copy link
Contributor

congiv commented Apr 12, 2024

Running falcon-sensor in an environment where the nodes will be deleted at the same time as/prior to the uninstall of falcon-sensor. In this case, the post-delete hook will never be schedulable because there are no nodes and the uninstall will hang indefinitely.

It would be nice if there was an option to disable this hook, as in my case I will never be uninstalling the falcon-sensor in a case where I'm not also deleting the whole cluster and its nodes.

@redhatrises
Copy link
Contributor

Please use --no-hooks for this.

@congiv
Copy link
Contributor Author

congiv commented Apr 12, 2024

@redhatrises I would, but I'm using ArgoCD where helm is only used as the templating engine. ArgoCD appears to have logic to translate a helm hook to its equivalent order during the (un)install.

For other similar use cases, I've only had success by toggling off the hook manifests that i don't need.

FYI: https://argo-cd.readthedocs.io/en/stable/user-guide/helm/#helm-hooks

@congiv
Copy link
Contributor Author

congiv commented Apr 13, 2024

I've opened a PR that addresses this, but keeps the default behavior that the hook is enabled. This way the general user can follow your recommendation around --no-hooks but gives users the flexibility to toggle off the manifests in use cases like mine where the helm bin isn't performing the uninstall, as with ArgoCD.

Thanks for your quick response and consideration, I really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants