diff --git a/doc/changelog.rst b/doc/changelog.rst index e67bb2117..6ba963cc0 100644 --- a/doc/changelog.rst +++ b/doc/changelog.rst @@ -8,6 +8,7 @@ To be released at some future point in time Description +- Remove unneeded method from Python SRObject class - Fixed a memory leak in the C layer - Remove debug output in pybind layer - Update Hiredis version to 1.1.0 @@ -24,6 +25,7 @@ Description Detailed Notes +- Remove from_pybind() from Python SRObject class as it's not needed and didn't work properly anyway (PR358_) - Fixed memory leaked from the C layer when calling get_string_option() (PR357_) - Remove debug output in pybind layer associated with put_dataset (PR352_) - Updated to the latest version of Hiredis (1.1.0) (PR351_) @@ -46,6 +48,7 @@ users need not import `iso_c_binding` in their own applications (PR340_) - New pip-install target in Makefile will be a dependency of the lib target going forward so that users don't have to manually pip install SmartRedis in the future (PR330_) - Added ConfigOptions class and API, which will form the backbone of multiDB support (PR303_) +.. _PR358: https://github.com/CrayLabs/SmartRedis/pull/358 .. _PR357: https://github.com/CrayLabs/SmartRedis/pull/357 .. _PR352: https://github.com/CrayLabs/SmartRedis/pull/352 .. _PR351: https://github.com/CrayLabs/SmartRedis/pull/351 diff --git a/src/python/module/smartredis/srobject.py b/src/python/module/smartredis/srobject.py index 787e6786b..d0cf2bff6 100644 --- a/src/python/module/smartredis/srobject.py +++ b/src/python/module/smartredis/srobject.py @@ -43,21 +43,6 @@ def __init__(self, context): else: self._srobject = context - @staticmethod - def from_pybind(srobject): - """Initialize a SRObject object from - a PySRObject object - - :param srobject: The pybind PySRObject object to use for construction - :type srobject: PySRObject - :return: The newly constructed¸ SRObject from the PySRObject - :rtype: SRObject - """ - typecheck(srobject, "srobject", PySRObject) - new_srobject = SRObject(srobject._name) - new_srobject.set_data(srobject) - return new_srobject - @exception_handler def get_srobject(self): """Return the PySRObject attribute