Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install with angular 1.4.12 #154

Closed
TM1584875DM opened this issue Sep 1, 2016 · 8 comments
Closed

Can't install with angular 1.4.12 #154

TM1584875DM opened this issue Sep 1, 2016 · 8 comments
Labels

Comments

@TM1584875DM
Copy link

In bower.json:
"dependencies": {
"angular": "1.4.0"
}
why not use "~1.4.0" ? Or angular version must be "1.4.0" ?

@rickerd
Copy link

rickerd commented Sep 1, 2016

Yesterday i've also seen this dependency and scratched my head.
I personally use angular 1.5.x in my project and it all works fine.
Do you @CrackerakiUA know why its failing?

I am working on a compile and test in Travis so im hoping to make better coverage and tests along the way.

@CrackerakiUA
Copy link
Owner

first time see this also )
i am also using latest angular 1.

@rickerd
Copy link

rickerd commented Sep 1, 2016

I will update this in master

@simison
Copy link

simison commented Sep 2, 2016

Hi! Does this work with Angular v1.5.x? :-) If it does, bower could be updated to reflect that.

@rickerd
Copy link

rickerd commented Sep 2, 2016

Yes + its already updated.
Check the master branch and bower.json file

@simison
Copy link

simison commented Sep 2, 2016

~1.4.0 matches only up to Angular 1.4.x, not Angular 1.5.x. You could require e.g. >=1.4.0 <1.6.0, >=1.4 or just 1.* instead.

Newest Angular v1 is 1.5.8, .9 just around the corner.

https://github.com/CrackerakiUA/ngImgCropFullExtended/blob/master/bower.json#L50

http://semver.org/
http://jubianchi.github.io/semver-check/

@rickerd
Copy link

rickerd commented Sep 2, 2016

Okay, make a PR for it.
Sorry i thought it worked with ~1.4

We can use your help

@simison
Copy link

simison commented Sep 2, 2016

^ done. 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants