Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are all parts of the address required? #30

Open
chmac opened this issue Jan 28, 2022 · 0 comments
Open

Are all parts of the address required? #30

chmac opened this issue Jan 28, 2022 · 0 comments
Assignees

Comments

@chmac
Copy link
Contributor

chmac commented Jan 28, 2022

The docs say:

Add an address as an ADR property. Fields not available should be null or undefined.

But the types say all fields are obligatory.

Hmm, although reading the code in more detail, perhaps it's the docs that are incorrect, and empty fields should be an empty string and not undefined or null?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants