Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated arguments from various constructors and functions #85

Closed
calebchiam opened this issue Feb 11, 2021 · 1 comment
Closed

Remove deprecated arguments from various constructors and functions #85

calebchiam opened this issue Feb 11, 2021 · 1 comment
Assignees
@calebchiam
Labels
enhancement good first issue ideal for first-time contributors

Comments

@calebchiam
Copy link
Collaborator

The current practice of leaving in deprecated constructor arguments is actually a bad practice because it can result in confusion when an informative IDE provides argument hints, for example:

image

We could just remove these outright and break backwards compatibility -- this might be reasonable as we approach the 1-year mark since these changes were made. Alternatively, we can continue to provide backwards compatibility by using variable keyword arguments in the constructor, i.e. **kwargs.
@calebchiam calebchiam added enhancement good first issue ideal for first-time contributors labels Feb 11, 2021
@calebchiam calebchiam assigned calebchiam and unassigned jschluger May 26, 2022
@calebchiam calebchiam mentioned this issue Sep 4, 2022
Merged
@calebchiam
Copy link
Collaborator Author

Resolved by #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calebchiam calebchiam

Labels
enhancement good first issue ideal for first-time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@calebchiam @jschluger