-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: endpoint to gracefully quit the container #35
Comments
Hello @pperzyna, is it possible to take a look at this request and share your thoughts? Thanks in advance, |
@AbdelrhmanHamouda, I am happy to review a PR |
A quick PR to add that endpoint: #36 |
Hello @pperzyna, it would be much appreciated if the proposed PR can be reviewed (and hopefully merged). For my use case, the proposed changes look like a very nice fit! This project is used in my organisation and having this limitation is causing some workarounds to be in place. It is not my intention to sound "pushy", however, the current workarounds are "ugly" and are not "cloud native" which is something i wish we can change soon. also, thanks @graipher for taking the time to put this PR in place :) Thanks in advance! |
@graipher thank you! |
EDIT, updated post from a vague request to a more defined one!
This is a feature request to add a
/quitquitquit
endpoint to the container to exit gracefully. This allows the container to be used as a part of a job/cronJob. This is identical to the/quitquitquit
exposed by istio in v1.3The text was updated successfully, but these errors were encountered: