Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: endpoint to gracefully quit the container #35

Closed
AbdelrhmanHamouda opened this issue Aug 12, 2022 · 5 comments
Closed
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AbdelrhmanHamouda
Copy link

AbdelrhmanHamouda commented Aug 12, 2022

EDIT, updated post from a vague request to a more defined one!

This is a feature request to add a /quitquitquit endpoint to the container to exit gracefully. This allows the container to be used as a part of a job/cronJob. This is identical to the /quitquitquit exposed by istio in v1.3

@AbdelrhmanHamouda AbdelrhmanHamouda changed the title Recommendation on correctly terminate the container when deployed in k8s Feature request: endpoint to gracefully quit the container Aug 16, 2022
@AbdelrhmanHamouda
Copy link
Author

Hello @pperzyna, is it possible to take a look at this request and share your thoughts?

Thanks in advance,

@pperzyna pperzyna added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 13, 2022
@pperzyna
Copy link
Contributor

@AbdelrhmanHamouda, I am happy to review a PR

@graipher
Copy link
Contributor

A quick PR to add that endpoint: #36

@AbdelrhmanHamouda
Copy link
Author

Hello @pperzyna, it would be much appreciated if the proposed PR can be reviewed (and hopefully merged). For my use case, the proposed changes look like a very nice fit!

This project is used in my organisation and having this limitation is causing some workarounds to be in place.

It is not my intention to sound "pushy", however, the current workarounds are "ugly" and are not "cloud native" which is something i wish we can change soon. also, thanks @graipher for taking the time to put this PR in place :)

Thanks in advance!

@pperzyna
Copy link
Contributor

@graipher thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants