Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference tests #4732

Closed
ajsutton opened this issue Dec 2, 2021 · 0 comments · Fixed by #4755
Closed

Update reference tests #4732

ajsutton opened this issue Dec 2, 2021 · 0 comments · Fixed by #4755
Assignees

Comments

@ajsutton
Copy link
Contributor

ajsutton commented Dec 2, 2021

Description

Update reference tests to 1.1.6. This release includes updates to fork_choice tests which expect proposer weight boosting to be enabled. We have it implemented but the fork choice test executor doesn't trigger events in the same way that a real node does and that's now important. We'll likely need to rework the test executor to call the ForkChoiceTrigger at appropriate times as part of the tick step in tests (and make sure we don't trigger changes to proposer weightings as part of running checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant