Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add latest_crosslink to AttestationData - (Spec PR #585) #391

Closed
schroedingerscode opened this issue Feb 26, 2019 · 1 comment
Closed

Add latest_crosslink to AttestationData - (Spec PR #585) #391

schroedingerscode opened this issue Feb 26, 2019 · 1 comment
Labels
enhancement 🕵️‍♀️ New feature or request
Milestone
Beacon Chain v0.4...

Comments

@schroedingerscode
Copy link
Contributor

Description

As an implementor, I want AttestationData to contain latest_crosslink so that it is calculable from within an attestation how many epochs said attestation spans, and that my client is compliant with the Beacon Chain spec v0.4.

Acceptance Criteria

  • AttestationData contains latest_crosslink (of type Crosslink) instead of latest_crosslink_root.
  • Relevant references are updated to comply with above. It is up to the implementor to verify operation, however some of these reference are:
    • The processAttestations method in BlockProcessorUtil.
    • The updateCrosslinks method in EpochProcessorUtil.
  • This change is adequately tested.

Additional Information

See ethereum/consensus-specs#585
@schroedingerscode schroedingerscode added the enhancement 🕵️‍♀️ New feature or request label Feb 26, 2019
@schroedingerscode schroedingerscode added the in progress 🚧 This issue or pull request is in progress label Feb 26, 2019
@vitorpy vitorpy mentioned this issue Feb 26, 2019
Merged
@schroedingerscode
Copy link
Contributor Author

Closed by #399

@schroedingerscode schroedingerscode removed the in progress 🚧 This issue or pull request is in progress label Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Milestone
Beacon Chain v0.4.0 Spec
Development

No branches or pull requests
1 participant
@schroedingerscode