Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use
mulWindowed
instead ofScalarMultiplication
is G1 and G2 subgroup membership and cofactor clearing methods.1- The point is still purported to be in the prime subgroup where GLV applies
2- multiplying by a small constant is faster with
mulWindowed
N.B.: multiplying e.g. twice by
x0
is faster than multiplying byx0^2
because it has smaller Hamming weight. E.g. for BLS12-381,mul-by-x0
is 64 dbl + 6 mul whilemul-by-x0^2
is 128 dbl + 17 mul. There is still room for improvement if needed by specialisingmul-by-x0
using a short addition chain.Type of change
Please delete options that are not relevant.
How has this been tested?
Same tests.
How has this been benchmarked?
Checklist:
golangci-lint
does not output errors locally