Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove helm chart #802

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Remove helm chart #802

merged 3 commits into from
Jun 14, 2023

Conversation

siladu
Copy link
Contributor

@siladu siladu commented Jun 14, 2023

Fixes #590

usmansaleem
usmansaleem approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jframe
jframe reviewed Jun 14, 2023
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add something into the changelog for removing the helm charts

@siladu
changelog
deecd83 
Signed-off-by: Simon Dudley <[email protected]>
@siladu siladu requested a review from jframe June 14, 2023 07:23
usmansaleem
usmansaleem approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siladu siladu merged commit df3916f into Consensys:master Jun 14, 2023
@siladu siladu deleted the remove-helm branch June 14, 2023 23:03
@siladu siladu mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usmansaleem usmansaleem usmansaleem approved these changes

@jframe jframe Awaiting requested review from jframe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove helm chart
3 participants
@siladu @usmansaleem @jframe