-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support prometheus push metrics #796
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…u library Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
usmansaleem
reviewed
Jun 13, 2023
usmansaleem
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jframe
reviewed
Jun 13, 2023
commandline/src/test/java/tech/pegasys/web3signer/commandline/CommandlineParserTest.java
Outdated
Show resolved
Hide resolved
…CommandlineParserTest.java Co-authored-by: Jason Frame <[email protected]>
jframe
approved these changes
Jun 13, 2023
usmansaleem
reviewed
Jun 13, 2023
commandline/src/main/java/tech/pegasys/web3signer/commandline/Web3SignerBaseCommand.java
Show resolved
Hide resolved
usmansaleem
reviewed
Jun 13, 2023
commandline/src/main/java/tech/pegasys/web3signer/commandline/Web3SignerBaseCommand.java
Show resolved
Hide resolved
usmansaleem
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - minor comment around checking for null.
jframe
approved these changes
Jun 13, 2023
Removing label because this issue is now in the Doc backlog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration for and pass through to Besu library, tested with Besu's instructions https://besu.hyperledger.org/en/stable/public-networks/how-to/monitor/metrics/#run-prometheus-with-besu-in-push-mode
Example CLI Usage:
Example config.yaml Usage
web3signer --config-file=config.yaml eth2
:Minimal Usage (using defaults):
Defaults:
Fixed Issue(s)
Fixes #790
Documentation
doc-change-required
label to this PR if updates are required.Changelog