Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate connector to SDK v0.13 #1

Merged
merged 21 commits into from
Feb 4, 2025
Merged

Migrate connector to SDK v0.13 #1

merged 21 commits into from
Feb 4, 2025

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Dec 19, 2024

Closes ConduitIO/conduit#2016.

This tool automates a number of actions needed to upgrade an existing connector to the SDK version that contains specgen.

@hariso hariso marked this pull request as ready for review January 3, 2025 12:08
@hariso hariso self-assigned this Jan 3, 2025
@raulb
Copy link
Member

raulb commented Jan 8, 2025

Removing from the Conduit Main board since it's connected already by ConduitIO/conduit#2016.

@hariso hariso requested a review from a team January 16, 2025 11:31
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest also adding conn-sdk-cli readmegen -w to the make generate target (like here), this way the connector is ready to use readmegen tags in the readme.

@hariso
Copy link
Contributor Author

hariso commented Jan 31, 2025

I suggest also adding conn-sdk-cli readmegen -w to the make generate target (like here), this way the connector is ready to use readmegen tags in the readme.

Yup, good idea! I plan to go over all the changes in the Postgres, and move as many of those as possible to this tool.

Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hariso hariso merged commit 976c716 into main Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connector.yaml: Automate updates for existing connectors (specgen, readmegen)
3 participants