Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse ToolkitSampleRenderer header when in Tabbed mode #79

Open
niels9001 opened this issue Jun 22, 2022 · 3 comments
Open

Collapse ToolkitSampleRenderer header when in Tabbed mode #79

niels9001 opened this issue Jun 22, 2022 · 3 comments
Assignees
Labels
sample app 🖼 ux 🖌️ Everything design related

Comments

@niels9001
Copy link
Collaborator

niels9001 commented Jun 22, 2022

In TabMode, users should not see the header of the page containing the title and description.

image

The VisualState to do this is part of CommunityToolkit/Labs-Windows#162, just needs the be wired up from code behind.

Edit swapped image with update for the header being discussed.

@michael-hawker
Copy link
Member

For the documentation render for the tabbed mode, I think that's fine. I was talking about the header in the sample mode here actually:

image

I may have just been tagging comments wrong in the PR since there's multiple github buttons...

@michael-hawker michael-hawker changed the title Collapse ToolkitDocumentationRenderer header when in Tabbed mode Collapse ToolkitSampleRenderer header when in Tabbed mode Jun 22, 2022
@niels9001
Copy link
Collaborator Author

For the documentation render for the tabbed mode, I think that's fine. I was talking about the header in the sample mode here actually:

image

I may have just been tagging comments wrong in the PR since there's multiple github buttons...

Yeah, that makes sense since we already have the sample name in the tab 👍

@michael-hawker
Copy link
Member

Just going to post this thought here for now, but in documentation view, we could have a tooltip with the sample description. Maybe we can use that on the tab header itself here as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sample app 🖼 ux 🖌️ Everything design related
Projects
None yet
Development

No branches or pull requests

2 participants