Multiple sample fail to build in CI/Codespaces duplicate GlobalStaticResources/Resource #110
Comments
|
@Arlodotexe we'll see if #109 works this time, it did seem like it built even though it got stuck. So not sure why this was only appearing in Codespaces (and locally with ios?) |
|
CI script working now! But oh, right of course it works as there's only one experiment in main at the moment. How do you want to proceed? Check-in the script and then we can see if a rebased #102 fails there in the new pipeline? |
michael-hawker
changed the title
|
Ah, this is showing up in the CI now for #102 now as well: https://github.com/CommunityToolkit/Labs-Windows/actions/runs/2304895236: May only be a WinUI 2 issue? |
|
This is one of the issues I first saw (weeks ago) as soon as it was possible to create new experiments from the template. #102 should have been reporting this as soon as it was created. That it didn't all along is a bit worrying. (What other issues are being hidden?) The issue is that separate libraries are created for each experiment and all are using the same namespace ( The simplest solution is probably to change the default namespace so that it includes the name of the experiment/project. |
|
nope happens for both WinUI 2 + 3 now that all other analysis errors are cleaned up: https://github.com/CommunityToolkit/Labs-Windows/actions/runs/2305824506 |
|
Talked to Jerome. This is a known Uno issue (see unoplatform/uno#8750). For now, we can just modify the default namespace in the csproj file? @Arlodotexe I think that'll be the simplest temporary solution. @mrlacey we do this in the main toolkit and want to keep the pattern here just to make it easier for folks to consume multiple packages and use in code without having to have like 6 different XMLNS in their XAML or using statements in code-behind. Changing it for now should be find as we're authoring the experiments, but it'd mean that VS would try and use it as the default namespace in new files which would break this pattern (though folders always make this problematic sometimes anyway for certain things). Let's test out the temp change and see how things go while we're waiting on an Uno fix in the future. |
|
Tested a workaround for this in my PR, noted here: #102 (comment) Working great on the linux build. I just appended Once that PR is in (and uno check is fixed, that should be the last bit to do final validation), then we can close this issue and open up a new issue for tracking uno fix. |
This change fixes uno-check, #114. Merge or cherry-pick at your convenience :) |
|
Opened up CommunityToolkit/Tooling-Windows-Submodule#130 for tracking as we've resolved the underlying issue this issue was opened against. |
Trying to run Codespaces on my #102 PR now that the source generator for documentation registry is fixed still causes this error:
Not sure what the
GlobalStaticResources.g.csfile is about. I created a new PR #109 to test running the same command on a linux environment for the CI. We should hopefully see those there as well (assuming I got the syntax right).The text was updated successfully, but these errors were encountered: