Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom configuration method for SqliteWeb #528

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lukedukeus
Copy link

**Closes #527 **

Adds config method to WithSqliteWeb.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@lukedukeus
Copy link
Author

@dotnet-policy-service agree

@aaronpowell
Copy link
Member

Ah good catch!

I think you'll need to update the Unshipped.txt for the integration with the method overload - VS should give a quick fix for that.

@lukedukeus
Copy link
Author

Thanks, I hadn't seen that analyzer before. Just updated it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom configuration method for SqliteWeb
2 participants