Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: When downloading missing model, add better indication of what the correct directory is #2353

Open
1 task done
christian-byrne opened this issue Jan 26, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@christian-byrne
Copy link
Collaborator

christian-byrne commented Jan 26, 2025

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

Add better indication of where a model should be downloaded in the missing models dialog:

Selection_814

It may not be obvious what the correct location is or that it will only work if the correct location is chosen, especially if this happens during your first time using ComfyUI.

Currently the parent directory is shown, but the absolute location is not obvious and it is also possibly not obvious that this refers to a directory name and just a category name.

Proposed workflow

  1. A workflow is loaded with a model field
  2. The user does not have the model downloaded
  3. The missing models dialog appears, asking if they want to download
  4. The user clicks the download button
  5. -- add some mechanism to indicate that this will only work if you download to a particular folder --
  6. The native file explorer window appears, and the user selects the correct location

Additional information

The correct directory is already included in the workflow moddel field:

    "models": [
      {
        "name": "flux1-schnell-fp8.safetensors",
        "url": "https://huggingface.co/Comfy-Org/flux1-schnell/resolve/main/flux1-schnell-fp8.safetensors?download=true",
        "directory": "checkpoints"
      }
    ],

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne added the enhancement New feature or request label Jan 26, 2025
@christian-byrne christian-byrne changed the title [Feature Request]: When downloading missing model, add some indication of what the correct directory is [Feature Request]: When downloading missing model, add better indication of what the correct directory is Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant