Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Remove hidden "Advanced Widgets" #2240

Open
1 task done
brknsoul opened this issue Jan 13, 2025 · 8 comments
Open
1 task done

[Feature Request]: Remove hidden "Advanced Widgets" #2240

brknsoul opened this issue Jan 13, 2025 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@brknsoul
Copy link

brknsoul commented Jan 13, 2025

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

Node Widgets should not be hidden by default.

Proposed workflow

n/a

Additional information

No response

┆Issue is synchronized with this Notion page by Unito

@brknsoul brknsoul added the enhancement New feature or request label Jan 13, 2025
@huchenlei
Copy link
Member

@pythongosssss Can you take a look at this issue?

We might want to drop the support for group node if we have subgraph planned on the horizon. In case it's too much effort to fix the group node.

@brknsoul
Copy link
Author

The issue is solved if the widget isn't hidden. If I knew the widget was there, I would have noticed the incorrect value.

It's difficult to debug something you can't see!

@christian-byrne
Copy link
Collaborator

The issue is solved if the widget isn't hidden. If I knew the widget was there, I would have noticed the incorrect value.

It's difficult to debug something you can't see!

Can you describe the issue that occurred? I don't fully understand.

@brknsoul
Copy link
Author

brknsoul commented Jan 14, 2025

This 'feature' is really unneeded

If you think it has future applications (currently, it only exists on CLIP loaders), then make a symbol or something with tooltip to indicate there are Advanced widgets hidden.

image

An off-the-cuff suggestion: the top-left minimize button could be a tri-state toggle; fully minimized, show partial, show all. One could right-click a widget and toggle it only shown in "show all". (the nomenclature could be better lol)

@JorgeR81
Copy link

This 'feature' is really unneeded

This would be more useful if we could select the widgets we want to hide.
We could use the right click menu for this ( like we do for converting widgets to input ).

If you think it has future applications (currently, it only exists on CLIP loaders), then make a symbol or something with tooltip to indicate there are Advanced widgets hidden.

An off-the-cuff suggestion: the top-left minimize button could be a tri-state toggle; fully minimized, show partial, show all.

I agree, we could have a tri-state button, when there are hidden widgets.
And in this case, the button could be a blue "dot" ( same color as the advanced widgets border ).

@JorgeR81
Copy link

We might want to drop the support for group node if we have subgraph planned on the horizon. In case it's too much effort to fix the group node.

I agree with this.
I like the concept of group nodes, but I never used them much, because of past issues.
I think having subgraphs would be better and would make group nodes mostly redundant.

@pythongosssss
Copy link
Member

pythongosssss commented Jan 14, 2025

This feature is unrelated to group nodes and was explicitly asked for by multiple developers in order to hide widgets that users should rarely need to interact with. The initial design was a tri-state indicator for it however it was deemed to be overly complex for the feature.

Edit:
Here was the original prototype, icons were just for demonstration not final:

2024-03-firefox_TZGCERHJFB.webm

@JorgeR81
Copy link

Here was the original prototype, icons were just for demonstration not final:

It looks great !
I hope we can have it in the future. Or something similar.


On a side note, the cg-controller extension also allows hiding widgets, and it's really useful.

https://github.com/chrisgoringe/cg-controller

fd1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants