From 950a81c3eeb602baf9ea92007dbb714dfa96207a Mon Sep 17 00:00:00 2001
From: Miklos Vajna <vmiklos@collabora.com>
Date: Fri, 16 Feb 2024 15:42:51 +0100
Subject: [PATCH] cool#8292 browser, clipboard: fix navigator.clipboard error
 handling

If the notebookbar's paste or paste special button is pressed and
Chrome's clipboard permisson popup is rejected, then nothing happened,
while Firefox case was showing a more helpful popup, explaining the
problem.

This has two sides: error handling should be better and also the error
should not happen in the first place. The error can also happen when the
<iframe> is not set up correctly, but that's to be handled on the
nextcloud side.

When there *is* an error, improve error handling by restoring the
codepath that matches Firefox:

- extract the rest of the code after invoking the async clipboard read
  in _execCopyCutPaste() to a new _afterCopyCutPaste()

- paste case: invoke _afterCopyCutPaste() when the paste fails

- paste special case: only pretend we're in paste special mode if the
  success fallback is called

  - if the failure callback is called, then invoke
    _openPasteSpecialPopup()

With this, the "has async clipboard, but the permission request
rejected" and the "don't have async clipboard" codepath matches.

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I727f00a1cf94dd1837e15e60410e1798de5daecc
---
 browser/src/map/Clipboard.js                  | 18 ++++++++--
 .../desktop/calc/clipboard_spec.js            | 35 ++++++++++++++++---
 2 files changed, 46 insertions(+), 7 deletions(-)

diff --git a/browser/src/map/Clipboard.js b/browser/src/map/Clipboard.js
index 9e2ddceeec48c..4760b820bd262 100644
--- a/browser/src/map/Clipboard.js
+++ b/browser/src/map/Clipboard.js
@@ -637,6 +637,11 @@ L.Clipboard = L.Class.extend({
 			return;
 		}
 
+		this._afterCopyCutPaste(operation);
+	},
+
+	_afterCopyCutPaste: function(operation) {
+		var serial = this._clipboardSerial;
 		this._unoCommandForCopyCutPaste = null;
 
 		// try a hidden div
@@ -762,18 +767,25 @@ L.Clipboard = L.Class.extend({
 			return false;
 		}
 
-		if (isSpecial) {
-			this._navigatorClipboardPasteSpecial = true;
-		}
 		var that = this;
 		var clipboard = navigator.clipboard;
 		if (L.Browser.cypressTest) {
 			clipboard = this._dummyClipboard;
 		}
 		clipboard.read().then(function(clipboardContents) {
+			if (isSpecial) {
+				that._navigatorClipboardPasteSpecial = true;
+			}
 			that._navigatorClipboardReadCallback(clipboardContents);
 		}, function(error) {
 			window.app.console.log('navigator.clipboard.read() failed: ' + error.message);
+			if (isSpecial) {
+				// Fallback to the old code, as in filterExecCopyPaste().
+				that._openPasteSpecialPopup();
+			} else {
+				// Fallback to the old code, as in _execCopyCutPaste().
+				that._afterCopyCutPaste('paste');
+			}
 		});
 		return true;
 	},
diff --git a/cypress_test/integration_tests/desktop/calc/clipboard_spec.js b/cypress_test/integration_tests/desktop/calc/clipboard_spec.js
index 2d4a620d3364c..25ed109c581e0 100644
--- a/cypress_test/integration_tests/desktop/calc/clipboard_spec.js
+++ b/cypress_test/integration_tests/desktop/calc/clipboard_spec.js
@@ -15,7 +15,7 @@ describe(['tagdesktop', 'tagnextcloud', 'tagproxy'], 'Calc clipboard tests.', fu
 		helper.afterAll(testFileName, this.currentTest.state);
 	});
 
-	function setDummyClipboard(type, content, image = false) {
+	function setDummyClipboard(type, content, image = false, fail = false) {
 		cy.window().then(win => {
 			var app = win['0'].app;
 			var metaURL = encodeURIComponent(app.map._clip.getMetaURL());
@@ -42,8 +42,14 @@ describe(['tagdesktop', 'tagnextcloud', 'tagproxy'], 'Calc clipboard tests.', fu
 			clipboard._dummyClipboard = {
 				read: function() {
 					return {
-						then: function(resolve/*, reject*/) {
-							resolve(clipboardItems);
+						then: function(resolve, reject) {
+							if (fail) {
+								reject({
+									message: 'rejected',
+								});
+							} else {
+								resolve(clipboardItems);
+							}
 						},
 					};
 				},
@@ -120,7 +126,28 @@ describe(['tagdesktop', 'tagnextcloud', 'tagproxy'], 'Calc clipboard tests.', fu
 		cy.cGet('#home-paste-button').click();
 		cy.cGet('#w2ui-overlay-pastemenu tr[title="Ctrl + V"]').click();
 
-		// Then make the paste happened:
+		// Then make sure the paste happened:
 		cy.cGet('.leaflet-pane.leaflet-overlay-pane svg g').should('exist');
 	});
+
+	it('HTML paste, internal case failing', function() {
+		// Given a document with an A1 cell copied to the clipboard:
+		cy.cGet('#map').focus();
+		calcHelper.clickOnFirstCell();
+		helper.typeIntoInputField('input#addressInput', 'A1');
+		cy.window().then(win => {
+			var app = win['0'].app;
+			app.socket.sendMessage('uno .uno:Copy');
+		});
+		var html = '<div id="meta-origin" data-coolorigin="%META_URL%">ignored</div>';
+		setDummyClipboard('text/html', html, /*image=*/false, /*fail=*/true);
+
+		// When pasting the clipboard to B1, which fails:
+		helper.typeIntoInputField('input#addressInput', 'B1');
+		cy.cGet('#home-paste-button').click();
+		cy.cGet('#w2ui-overlay-pastemenu tr[title="Ctrl + V"]').click();
+
+		// Then make sure a warning popup is shown:
+		cy.cGet('#copy_paste_warning-box').should('exist');
+	});
 });