Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move files to utils? #164

Closed
dpizetta opened this issue May 6, 2019 · 4 comments
Closed

Move files to utils? #164

dpizetta opened this issue May 6, 2019 · 4 comments
Assignees
Milestone

Comments

@dpizetta
Copy link
Collaborator

dpizetta commented May 6, 2019

In my opinion, we should move some files:

  • process_qrc.py > qdarkstyle/utils/qrc.py (compile qrc)
  • palette.py > qdarkstyle/utils/palette.py (check palette contrast)

Because they are required if you want to generate the files by yourself up to compiled.

And these ones, if wanted to check a standard example window.

  • process_ui.py > qdarkstyle/utils/ui.py
  • run_ui_css_edition.py > qdarkstyle/utils/ui_style_edition.py
  • example > qdarkstyle/example

Also, should we provide the 'example' to run the ui_style_edition.

@ColinDuquesnoy @goanpeca opinions?

@goanpeca
Copy link
Collaborator

goanpeca commented May 6, 2019

Hi @dpizetta I agree with all your suggestions

@dpizetta dpizetta added this to the 2.7 milestone May 6, 2019
@goanpeca
Copy link
Collaborator

goanpeca commented May 6, 2019

The only thing to keep in mind is that for conda packages there will be no qtsass (libsass cannot be compiled with VS2008 which is what is required for winpy27) available for windows py27 so all that toolchain will not be available for that specific case.

With pypi there should not be a problem.

They will be able to still use the package normally but no custom palette creation at runtime.

@dpizetta
Copy link
Collaborator Author

dpizetta commented May 6, 2019

Since py27 is going to die soon, I think that there is no problems. As well as py34 will too. Things after py36 are much better for qt things as we can simple install pyqt/pyside from pypi. Actually, I was propose to us to keep some dates/versions of compatible python distribution. Many things we can't do with py27.

@dpizetta dpizetta self-assigned this May 21, 2019
@dpizetta dpizetta modified the milestones: 2.7, 2.9 May 29, 2019
@dpizetta dpizetta modified the milestones: 2.9, 3.0 Mar 29, 2021
@dpizetta
Copy link
Collaborator Author

Implemented in v3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants