Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linter] warning about URL when it seems valid. #130

Closed
squarefrog opened this issue May 14, 2014 · 4 comments
Closed

[Linter] warning about URL when it seems valid. #130

squarefrog opened this issue May 14, 2014 · 4 comments

Comments

@squarefrog
Copy link
Contributor

I've just merged a pull request which was failing Travis due to an error

- WARN  | There was a problem validating the URL /.

This is due to the redirect happening.

→ curl -I http://dynamicxray.net/
HTTP/1.1 302 Found
Connection: close
Pragma: no-cache
cache-control: no-cache
Location: /

I'm certain I've created an issue for something similar in the past, but I can't seem to find it so forgive me!

/cc @alloy

@squarefrog
Copy link
Contributor Author

Closing as fixed in #115

@kylef
Copy link
Contributor

kylef commented May 14, 2014

This isn't a valid URL. Its an infinite loop. http://dynamicxray.net/ redirects to / which is the same URL.

I've noticed that the same URL returns a 200 for a GET request, but infinitely redirects for HEAD requests. I'd say this is a problem as their end.

There is another problem I spotted here, - WARN | There was a problem validating the URL /. should show the absolute url.

-- WARN  | There was a problem validating the URL /.
+- WARN  | There was a problem validating the URL http://dynamicxray.net/.

@squarefrog
Copy link
Contributor Author

👍

@alloy
Copy link
Member

alloy commented May 14, 2014

@kylef Good points 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants