From 64dd68f0ca2f7218956af3260d6748f9ebfa68fb Mon Sep 17 00:00:00 2001 From: Florian Sanders Date: Tue, 17 Dec 2024 11:46:52 +0100 Subject: [PATCH 1/2] chore(eslint/eslint-config-clever-cloud-esm): enable `import/extensions` --- eslint/javascript/eslint-config-clever-cloud-esm.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eslint/javascript/eslint-config-clever-cloud-esm.js b/eslint/javascript/eslint-config-clever-cloud-esm.js index 392f4d9cf..cebebf463 100644 --- a/eslint/javascript/eslint-config-clever-cloud-esm.js +++ b/eslint/javascript/eslint-config-clever-cloud-esm.js @@ -37,7 +37,7 @@ export default { 'import/no-unresolved': 'off', // quite a few false negative with this one 'import/named': 'off', - 'import/extensions': 'off', + 'import/extensions': ['error', 'always'], 'import/first': 'error', 'import/newline-after-import': ['error', { count: 1 }], 'import/no-useless-path-segments': ['error', { noUselessIndex: true }], From 32b13aa2322ec63e88f8f3742dacbfdbade4e92b Mon Sep 17 00:00:00 2001 From: Florian Sanders Date: Tue, 17 Dec 2024 11:48:44 +0100 Subject: [PATCH 2/2] chore(eslint/eslint-config-clever-cloud-esm): enable `import/no-unresolved` --- .storybook/preview.js | 1 + eslint/javascript/eslint-config-clever-cloud-esm.js | 3 +-- src/stories/lib/make-story.js | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.storybook/preview.js b/.storybook/preview.js index 0dc56ffbd..90c2186da 100644 --- a/.storybook/preview.js +++ b/.storybook/preview.js @@ -2,6 +2,7 @@ import { setCustomElementsManifest } from '@storybook/web-components'; // Any CSS file import automagically generates a `` in the story iframe import 'github-markdown-css/github-markdown.css'; import 'highlight.js/styles/vs.css'; +// eslint-disable-next-line import/no-unresolved import customElementsManifest from '../dist/custom-elements.json'; import { AutodocsTemplate } from '../src/stories/lib/autodocs-template.jsx'; import '../src/stories/lib/i18n-control.js'; diff --git a/eslint/javascript/eslint-config-clever-cloud-esm.js b/eslint/javascript/eslint-config-clever-cloud-esm.js index cebebf463..ce8e0075c 100644 --- a/eslint/javascript/eslint-config-clever-cloud-esm.js +++ b/eslint/javascript/eslint-config-clever-cloud-esm.js @@ -33,10 +33,9 @@ export default { 'no-new': 'off', 'no-unused-vars': ['error', { argsIgnorePattern: '^_', varsIgnorePattern: '^_', ignoreRestSiblings: true }], // import plugin - // some rules are disabled because TypeScript already handles it - 'import/no-unresolved': 'off', // quite a few false negative with this one 'import/named': 'off', + 'import/no-unresolved': 'error', 'import/extensions': ['error', 'always'], 'import/first': 'error', 'import/newline-after-import': ['error', { count: 1 }], diff --git a/src/stories/lib/make-story.js b/src/stories/lib/make-story.js index 7c5bde254..932b660e1 100644 --- a/src/stories/lib/make-story.js +++ b/src/stories/lib/make-story.js @@ -1,3 +1,4 @@ +// eslint-disable-next-line import/no-unresolved import customElementsManifest from '../../../dist/custom-elements.json'; import { setLanguage } from '../../lib/i18n/i18n.js'; import { sequence } from './sequence.js';