Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint: investigate using eslint-plugin-promise #1248

Open
florian-sanders-cc opened this issue Nov 25, 2024 · 0 comments
Open

eslint: investigate using eslint-plugin-promise #1248

florian-sanders-cc opened this issue Nov 25, 2024 · 0 comments
Assignees
Labels
maintenance Code refactoring, project structure, dev tooling (storybook, dev server, npm tasks...)

Comments

@florian-sanders-cc
Copy link
Contributor

Context

It seems we're not using eslint-plugin-promise anymore.

It is part of our dependencies but we have not enabled any rule yet.

With the migration to ESLint 9, we have removed this plugin from our dependencies but we should investigate rules that we want to enable / disable.

The recommended config contains some rules that trigger many errors in our code base which we don't really consider problematic.

For instance it forces us to always return something in then so that it can always be chained but there are plenty of cases where we don't really want / need to do that (for instance this.updateComplete.then(() => ...)).

Investigating all rules & their impact in our code base required time I didn't have but when we do have this time we should definitely do it.

@florian-sanders-cc florian-sanders-cc added the maintenance Code refactoring, project structure, dev tooling (storybook, dev server, npm tasks...) label Nov 25, 2024
@florian-sanders-cc florian-sanders-cc self-assigned this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code refactoring, project structure, dev tooling (storybook, dev server, npm tasks...)
Projects
None yet
Development

No branches or pull requests

1 participant