-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] implement dealing with OCI registry #43
Comments
Are there any plans to implement this feature? |
@imanushin @magner669 - what do we think about @bsgrd's proposal? |
How about adapting the snippet (unbroken-dome#155 (comment)) to actual helm-plugin architecture\language |
@bademux, thank you. It seems like it would be very easy to add this support. However the question is how it would be better to test this feature. I will check some options and return later. If there are any approaches which could be applied via GitHub Actions then I will be happy to add them. |
You need to decide what are you testing (the scope). |
This is an important feature. I think we would need unit testing with mocks , but we also need a test with a real OCI repo. Do you have one handy @bademux ? |
AWS ECR supports OCI, Artifactory as well. There is official Docker of OCI registry https://hub.docker.com/_/registry. Technically helm OCI image is 2 layers - first with manifest and second is compressed tar full of yamls. So assertion in test is really simple with this knowledge. |
Good. I'd just like to clarify what I think shuld be the test requirement here. In the build, I think we shouldn't have a dependency on some helm chart with some version at a third party/external OCI repo. By murphys law, it will break and we will have to fix it in a hurry . That's why I suggested to use mocks. It would be suffecient to manually test with a real repo and provide a screenshot in the PR as test evidence. |
Hello, I’m currently using the Gradle Helm Plugin to manage Helm charts within my project. We have a requirement to use OCI-based Helm charts hosted in a Docker registry (e.g., Docker Hub or Harbor). As Helm now natively supports OCI registries (via the HELM_EXPERIMENTAL_OCI=1 environment variable), we attempted to configure the plugin to work with our OCI registry. However, the plugin does not support this out of the box, leading to issues when updating chart dependencies in an OCI registry. Critical feature. |
@imanushin @magner669 - following on from @iamaverrick comments above, can we think about what we need to push this over the line? Is anyone willing to support in the development of this? |
no need to set |
How would I use this plugin with registries the already adapted OCI, such as Harbor, etc? This plugin should implement the ability to use either or. |
@iamaverrick I'm not sure I understand the question, but OCI registry references are always prefixed with |
Ok, basically when using the plugin I'm unable to use the plugin due to the fact that the plugin uses URL, instead of OCI, so the builds fails. I understand that OCI is no longer an experimental feature it's stable in helm, and harbor. This plugin doesn't support OCI, if it does please advise how. Thank you in advance |
@iamaverrick as mentioned several comments before, impl it by yourself as a custom task. |
Implement dealing with OCI registry
Migrating Feature Request unbroken-dome#155
The text was updated successfully, but these errors were encountered: