Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chucker does not recognise partially read responses #287

Closed
MiSikora opened this issue Mar 26, 2020 · 0 comments · Fixed by #288
Closed

Chucker does not recognise partially read responses #287

MiSikora opened this issue Mar 26, 2020 · 0 comments · Fixed by #288
Labels
bug Something isn't working
Milestone
3.2.0

Comments

@MiSikora
Copy link
Contributor

✍️ Describe the bug

When only some portion of the upstream is read from the response it might fail when Chucker tries to read it back for processing. For example GzipSource expects that after it is done with the content there will be CRC32 checksum in the footer. If it is not present it will throw an exception and crash.

💣 Steps to reproduce

Creating an example is doable but it is reported by @oakkitten in a follow-up discussion to #263.

🔧 Expected behavior

Chucker dismisses incomplete responses. This behaviour is consistent with maximum content length allowed.
@MiSikora MiSikora mentioned this issue Mar 26, 2020
Merged
@ghost ghost added the Pending PR The resolution for the issue is in PR label Mar 26, 2020
@MiSikora MiSikora mentioned this issue Mar 26, 2020
Closed
@ghost ghost removed the Pending PR The resolution for the issue is in PR label Mar 27, 2020
@cortinico cortinico added this to the 3.2.0 milestone Mar 28, 2020
@cortinico cortinico added the bug Something isn't working label Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.2.0
Development

Successfully merging a pull request may close this issue.

Properly handle unexhausted network responses
2 participants
@cortinico @MiSikora