From d390ee14570eb6feef65db738666d9d8cb404aca Mon Sep 17 00:00:00 2001 From: amasyk Date: Tue, 24 Mar 2020 11:27:20 +0100 Subject: [PATCH] format utils test refactor (#285) * format utils test refactor * share text test refactor --- .../support/FormatUtilsSharedTextTest.kt | 18 +++++++++++------- .../internal/support/FormatUtilsTest.kt | 4 ++-- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/library/src/test/java/com/chuckerteam/chucker/internal/support/FormatUtilsSharedTextTest.kt b/library/src/test/java/com/chuckerteam/chucker/internal/support/FormatUtilsSharedTextTest.kt index 6770767ac..efb0c6f16 100644 --- a/library/src/test/java/com/chuckerteam/chucker/internal/support/FormatUtilsSharedTextTest.kt +++ b/library/src/test/java/com/chuckerteam/chucker/internal/support/FormatUtilsSharedTextTest.kt @@ -31,17 +31,21 @@ class FormatUtilsSharedTextTest { @Test fun getShareTextForGetTransaction() { - Truth.assertThat( - FormatUtils.getShareText(contextMock, TestTransactionFactory.createTransaction("GET"), false) - ) - .isEqualTo(TestTransactionFactory.expectedGetHttpTransaction) + val shareText = getShareText("GET") + Truth.assertThat(shareText).isEqualTo(TestTransactionFactory.expectedGetHttpTransaction) } @Test fun getShareTextForPostTransaction() { - Truth.assertThat( - FormatUtils.getShareText(contextMock, TestTransactionFactory.createTransaction("POST"), false) + val shareText = getShareText("POST") + Truth.assertThat(shareText).isEqualTo(TestTransactionFactory.expectedHttpPostTransaction) + } + + private fun getShareText(method: String): String { + return FormatUtils.getShareText( + contextMock, + TestTransactionFactory.createTransaction(method), + false ) - .isEqualTo(TestTransactionFactory.expectedHttpPostTransaction) } } diff --git a/library/src/test/java/com/chuckerteam/chucker/internal/support/FormatUtilsTest.kt b/library/src/test/java/com/chuckerteam/chucker/internal/support/FormatUtilsTest.kt index 3294802a1..058a4213f 100644 --- a/library/src/test/java/com/chuckerteam/chucker/internal/support/FormatUtilsTest.kt +++ b/library/src/test/java/com/chuckerteam/chucker/internal/support/FormatUtilsTest.kt @@ -122,12 +122,12 @@ class FormatUtilsTest { } @Test - fun formatXml_emptyString() { + fun testFormatXml_emptyString() { assertThat(FormatUtils.formatXml("")).isEmpty() } @Test - fun formatXml_properXml() { + fun testFormatXml_properXml() { val xml = """ value