Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to NPCResult #699

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Remove references to NPCResult #699

merged 2 commits into from
Sep 17, 2024

Conversation

matt-o-how
Copy link
Contributor

A straightforward variable rename

@matt-o-how matt-o-how requested a review from arvidn September 3, 2024 14:40
@Rigidity
Copy link
Contributor

Rigidity commented Sep 3, 2024

Would conditions be a more readable alternative to osbc?

Copy link

coveralls-official bot commented Sep 3, 2024

Pull Request Test Coverage Report for Build 10847172810

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 83.953%

Totals Coverage Status
Change from base Build 10636956337: 0.002%
Covered Lines: 12373
Relevant Lines: 14738

💛 - Coveralls

@arvidn
Copy link
Contributor

arvidn commented Sep 5, 2024

It's not obvious to me that this name is an improvement.

@arvidn arvidn merged commit 2aa206c into main Sep 17, 2024
60 checks passed
@arvidn arvidn deleted the remove_npc_references branch September 17, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants