Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose from_seed in SecretKey to python as well #590

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

Quexington
Copy link
Contributor

This is another method it would be helpful to have exposed on the python side

@Rigidity
Copy link
Contributor

Two things - you'll need to update generate_type_stubs and run the file to update the chia_rs.pyi file rather than doing it by hand

And Self::from_seed is probably what you're trying to do here - this is an associated function on the struct rather than an instance method

@Rigidity
Copy link
Contributor

Otherwise, lgtm

Copy link

coveralls-official bot commented Jun 26, 2024

Pull Request Test Coverage Report for Build 9687017499

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 287 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+2.0%) to 80.738%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-bls/src/secret_key.rs 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
crates/chia-protocol/src/classgroup.rs 1 0.0%
crates/chia-bls/src/error.rs 4 0.0%
crates/chia-traits/src/streamable.rs 9 92.54%
crates/chia-bls/src/secret_key.rs 11 89.29%
crates/chia-bls/src/signature.rs 19 93.94%
crates/chia-bls/src/public_key.rs 19 90.45%
wheel/src/api.rs 43 66.67%
crates/chia-bls/src/gtelement.rs 47 9.47%
crates/chia-bls/src/bls_cache.rs 51 73.16%
crates/chia-protocol/src/block_record.rs 83 0.0%
Totals Coverage Status
Change from base Build 9645397669: 2.0%
Covered Lines: 11393
Relevant Lines: 14111

💛 - Coveralls

@Rigidity Rigidity merged commit 4e6bfd8 into main Jul 8, 2024
65 checks passed
@Rigidity Rigidity deleted the quex.from_seed branch July 8, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants